-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More work on vignettes #879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
force-pushed
the
more-work-on-vignettes
branch
from
November 10, 2022 04:55
5084c29
to
61f6d3a
Compare
jennybc
force-pushed
the
more-work-on-vignettes
branch
from
November 16, 2022 18:44
0315c41
to
21dd700
Compare
hadley
reviewed
Nov 16, 2022
hadley
reviewed
Nov 16, 2022
hadley
reviewed
Nov 16, 2022
Co-authored-by: Hadley Wickham <[email protected]>
I removed instead of replaced because there are no cross-refs.
Still looking for a genuine system.file() example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619, closes #689
This PR inspired this issue for future consideration: r-lib/devtools#2485.