Skip queue count check #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geertiebear
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Could we maybe add a message that tells them the consequences of this? (and instructions on how to make sure all packets arrive to the correct queue). Because as of right now this is sort of a dangerous toggle, it could lead to the tool being seriously degraded.
Also this doesn't resolve all the issues that people have reported in #25, we still have the thread and queue count mismatch issue.
Geertiebear
approved these changes
Oct 25, 2024
Geertiebear
force-pushed
the
skip_queue_count_check
branch
from
edd2373
to
e86f04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give users the option to skip the queue count check