-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/initia #182
base: dev
Are you sure you want to change the base?
Feat/initia #182
Conversation
20061ff
to
794e277
Compare
} | ||
|
||
fn query_non_native_rewards_balances(deps: Deps<NeutronQuery>) -> ContractResult<Binary> { | ||
let data = NON_NATIVE_REWARD_BALANCES.load(deps.storage)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it always contains value? Maybe implement it like in the balances and delegations query?
ExecuteMsg::TokenizeShare { | ||
validator, | ||
amount, | ||
reply_to, | ||
} => execute_tokenize_share(deps, info, validator, amount, reply_to), | ||
ExecuteMsg::RedeemShares { items, reply_to } => { | ||
execute_redeem_shares(deps, info, items, reply_to) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better return error for shares methods call because there is not shares in the initia
config.clone(), | ||
vec![prepare_any_msg( | ||
redelegate_msg, | ||
"/cosmos.staking.v1beta1.MsgBeginRedelegate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check transaction type
} | ||
if messages.is_empty() { | ||
submessages.push(SubMsg::reply_on_success( | ||
new_multiple_balances_query_msg( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this query will work with initia? Maybe it is better to return "not implemented", anyway this code will not work
)?; | ||
|
||
Ok(SubMsg::reply_on_success( | ||
new_register_delegator_unbonding_delegations_query_msg( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know unbonding delegations is not used anymore, maybe we can deprecate this method in this version of puppeteer?
let mut delegations: Vec<DropDelegation> = Vec::with_capacity(total_validators); | ||
|
||
if total_validators > 0 { | ||
println!("total_validators {}", total_validators); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this debug outpout
_amount: Uint128, | ||
_reply_to: String, | ||
) -> ContractResult<Response<NeutronMsg>> { | ||
panic!("Not implemented") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unimplemented!() is better
panic!("Not implemented") | |
unimplemented!() |
_items: Vec<RedeemShareItem>, | ||
_reply_to: String, | ||
) -> ContractResult<Response<NeutronMsg>> { | ||
panic!("Not implemented") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic!("Not implemented") | |
unimplemented!() |
Task