Replace NFT with denoms #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
3 times, most recently
from
98e23cc
to
b2d6808
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
3 times, most recently
from
81d321f
to
09d7218
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
2 times, most recently
from
f9dc653
to
76b520a
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
from
76b520a
to
897ebea
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
2 times, most recently
from
3e395b3
to
f460932
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
2 times, most recently
from
b02d306
to
df38ce3
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
from
df38ce3
to
ec5f540
Compare
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
from
909e9d2
to
47b920c
Compare
deniszagumennov
requested review from
ratik,
foxpy,
faust403,
albertandrejev and
oldremez
faust403
reviewed
Oct 16, 2024
deniszagumennov
force-pushed
the
feat/withdrawal-token
branch
from
4260c1d
to
688c0e2
Compare
|
I think overall you are going in a correct direction, I didn't find any major flaws in your code. Please take a careful look at a bunch of suggestions and comments I prepared here: #190 P.S. I thought it would be more convenient to write some code instead of using the Github's review system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.