Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HaikuPorter: Move Reporters into dedicated subdirectory #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HaikuPorter: Move Reporters into dedicated subdirectory #255

wants to merge 1 commit into from

Conversation

kallisti5
Copy link
Member

No description provided.

@kallisti5
Copy link
Member Author

A silly cleanup that was mentioned a while ago :-)

jurgenwigg
jurgenwigg suggested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jurgenwigg jurgenwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/update this PR to the latest repo. I suggest changing files name to Mongo.py and Json.py and importing them with:

from .Reporters.Mongo import ReporterMongo
from .Reporters.Json import ReporterJson

It is a little cleaner solution :)

@Begasus
Copy link
Contributor

Begasus commented Jun 15, 2024

@kallisti5 could you have a look here? 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurgenwigg jurgenwigg jurgenwigg requested changes

@waddlesplash waddlesplash waddlesplash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kallisti5 @Begasus @waddlesplash @jurgenwigg