Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSR (as client-side library) #1

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Conversation

budnix
Copy link
Member

@budnix budnix commented Dec 8, 2023

The PR adds SSR support as a client-side library. These changes involve:

  • Removed direct references to the window, and document objects. They are still there but are used after module initialization;
  • Added the export key in the package.json file to support ESM, CJS, and UMD builds;
  • Added GH workflow for tests;
  • Removed code that tried to detect the moment module as it was not compatibe with ESM. Instead, I added a new useMoment method that can be used to tell the Pikaday to use it;
  • Added TS types;

@budnix budnix self-assigned this Dec 8, 2023
@budnix budnix merged commit c1117b4 into develop Dec 11, 2023
1 check passed
@budnix budnix deleted the feature/ssr-support branch December 11, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant