Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor text properties #43

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Refactor text properties #43

merged 3 commits into from
Mar 10, 2024

Conversation

hanjinliu
Copy link
Owner

Closes #39
Also improve performance of vispy text layer.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 90.68627% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 83.87%. Comparing base (1bc0a45) to head (c331e05).

Files Patch % Lines
whitecanvas/backend/vispy/text.py 75.40% 8 Missing and 7 partials ⚠️
whitecanvas/layers/_mixin.py 84.61% 1 Missing and 1 partial ⚠️
whitecanvas/backend/bokeh/text.py 98.55% 1 Missing ⚠️
whitecanvas/layers/group/labeled.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   83.88%   83.87%   -0.02%     
==========================================
  Files         162      162              
  Lines       18366    18304      -62     
  Branches     3127     3093      -34     
==========================================
- Hits        15407    15352      -55     
  Misses       2141     2141              
+ Partials      818      811       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanjinliu hanjinliu merged commit e8b729f into main Mar 10, 2024
14 of 15 checks passed
@hanjinliu hanjinliu deleted the text-props branch March 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text properties should not necessarily be arrays
1 participant