Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D canvas #53

Merged
merged 10 commits into from
May 12, 2024
Merged

3D canvas #53

merged 10 commits into from
May 12, 2024

Conversation

hanjinliu
Copy link
Owner

This PR implements 3D canvas for backends that support it.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 16.90418% with 1691 lines in your changes are missing coverage. Please review.

Project coverage is 77.56%. Comparing base (e6ca691) to head (a4468ca).

Files Patch % Lines
whitecanvas/canvas/canvas3d/_base.py 0.00% 248 Missing ⚠️
whitecanvas/layers/layer3d/markers.py 0.00% 165 Missing ⚠️
whitecanvas/layers/layer3d/vectors.py 0.00% 115 Missing ⚠️
whitecanvas/backend/vispy/components3d/axis.py 0.00% 88 Missing ⚠️
...ecanvas/backend/matplotlib/components3d/markers.py 0.00% 78 Missing ⚠️
...tecanvas/backend/matplotlib/components3d/canvas.py 0.00% 70 Missing ⚠️
whitecanvas/backend/vispy/components3d/canvas.py 0.00% 64 Missing ⚠️
whitecanvas/layers/_primitive/vectors.py 44.82% 64 Missing ⚠️
whitecanvas/backend/plotly/components3d/markers.py 0.00% 56 Missing ⚠️
whitecanvas/backend/pyqtgraph/vectors.py 32.09% 55 Missing ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   84.11%   77.56%   -6.55%     
==========================================
  Files         168      195      +27     
  Lines       19170    20966    +1796     
  Branches     3200     3408     +208     
==========================================
+ Hits        16124    16263     +139     
- Misses       2200     3855    +1655     
- Partials      846      848       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanjinliu hanjinliu merged commit e802834 into main May 12, 2024
13 of 15 checks passed
@hanjinliu hanjinliu deleted the canvas3d branch May 12, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant