fix: bug all vault search not working #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// NOTES: this didn't work if the file was on another directory because the path could include the folder names
// which implied if the file was in a subfolder, it couldn't find the file correctly.
|
It's sad that this is not maintained |
|
@hans i think you should at least find some maintainers if you don't have time, so the project could keep going. This plugin is so nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code didn't work if the file was on another directory because the path could include the folder names which implied if the file was in a subfolder, it couldn't find the file correctly.
It worked only for files in the same exact directory, with different case.
This PR fixes that and allows for vault wide search.
Implements #219 .