Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md #219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update CHANGELOG.md #219

wants to merge 2 commits into from

Conversation

hanwen-pcluste
Copy link
Owner

Description of changes

  • Describe what you're changing and why you're doing these changes.

Tests

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hanwen-pcluste and others added 2 commits July 10, 2024 11:21
@hanwen-pcluste
[integ-tests] Fix test_create_wrong_pcluster_version
4473460 
The failure was not signaled to CloudFormation via cfn-signal with version 3.6.1 because of this change aws@aeb87fc. In particular, for whatever version<3.10.0 the envar $CFN_BOOTSTRAP_VIRTUALENV_PATH is not set and so the cfn-signal command is not resolved.

Therefore, we change the version to 3.10.0 vs 3.11.0 to make ``$CFN_BOOTSTRAP_VIRTUALENV_PATH` setup consistent.

Signed-off-by: Hanwen <[email protected]>
@hanwen-pcluste
Update CHANGELOG.md
9b5462a
@spackbot-app spackbot-app bot added the core label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanwen-pcluste