add DAI and 1sDAI #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technical side looks good, approved. |
leonimella
approved these changes
Dec 12, 2024
msvstj
approved these changes
Dec 13, 2024
tokenlist.json
Outdated
| "chainId": 1666600000, | ||
| "address": "0xeDEb95D51dBc4116039435379Bd58472A2c09b1f", | ||
| "symbol": "1sDAI", | ||
| "name": "1sDAI", |
There was a problem hiding this comment.
Hello @sophoah , the technical side is good overall and would be no problem to merge, but just minor update - token name differs from the one stored in contract, and due to contract not being verified could have been missed.
name: Savings Dai
tokenlist.json
Outdated
| "chainId": 1666600000, | ||
| "address": "0xd068722E4e1387E4958300D1e625d2878f784125", | ||
| "symbol": "1DAI", | ||
| "name": "1DAI", |
There was a problem hiding this comment.
Hello @sophoah , the technical side is good overall, just minor update - token name differs from the one stored in contract and due to contract not being verified could have been missed.
name: DAI Stablecoin
After the change the PR will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.