Mark those unavailable addons on ARM64 #605
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ title: "VM Import" | |||||
|
|
||||||
| _Available as of v1.1.0_ | ||||||
|
|
||||||
| _Unavailable on ARM64 architecture_ | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| Beginning with v1.1.0, users can import their virtual machines from VMWare and OpenStack into Harvester. | ||||||
|
|
||||||
| This is accomplished using the vm-import-controller addon. | ||||||
|
|
@@ -184,4 +186,4 @@ spec: | |||||
|
|
||||||
| :::note | ||||||
| OpenStack allows users to have multiple instances with the same name. In such a scenario, users are advised to use the Instance ID. The reconciliation logic tries to perform a name-to-ID lookup when a name is used. | ||||||
| ::: | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ title: "PCI Devices" | |||||
|
|
||||||
| _Available as of v1.1.0_ | ||||||
|
|
||||||
| _Unavailable on ARM64 architecture_ | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| A `PCIDevice` in Harvester represents a host device with a PCI address. | ||||||
| The devices can be passed through the hypervisor to a VM by creating a `PCIDeviceClaim` resource, | ||||||
| or by using the UI to enable passthrough. Passing a device through the hypervisor means that | ||||||
|
|
@@ -94,4 +96,4 @@ We have also introduced a new filter to help you filter PCI devices by the under | |||||
|  | ||||||
|
|
||||||
| The newly created PCI device can be passed through to virtual machines like any other PCI device. | ||||||
|  | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ title: "Seeder" | |||||
|
|
||||||
| _Available as of v1.2.0_ | ||||||
|
|
||||||
| _Unavailable on ARM64 architecture_ | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| The `harvester-seeder` addon lets you perform out-of-band operations on underlying nodes. | ||||||
|
|
||||||
| This addon can also discover hardware and hardware events for bare-metal nodes that support redfish-based access and then associate the hardware with the corresponding Harvester nodes. | ||||||
|
|
@@ -52,4 +54,4 @@ This information is associated with Harvester nodes and can be used as Kubernete | |||||
|
|
||||||
| Sometimes, the `Out-Of-Band Access` section may be stuck with the message `Waiting for "inventories.metal.harvesterhci.io" to be ready`. In this case, you need to refresh the page. For more information, see [this issue](https://github.com/harvester/harvester/issues/4412). | ||||||
|
|
||||||
| ::: | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ title: "VM Import" | |||||
|
|
||||||
| _Available as of v1.1.0_ | ||||||
|
|
||||||
| _Unavailable on ARM64 architecture_ | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| Beginning with v1.1.0, users can import their virtual machines from VMWare and OpenStack into Harvester. | ||||||
|
|
||||||
| This is accomplished using the vm-import-controller addon. | ||||||
|
|
@@ -184,4 +186,4 @@ spec: | |||||
|
|
||||||
| :::note | ||||||
| OpenStack allows users to have multiple instances with the same name. In such a scenario, users are advised to use the Instance ID. The reconciliation logic tries to perform a name-to-ID lookup when a name is used. | ||||||
| ::: | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have content like
_Available as of v1.2.0_, I would prefer_Unavailable on ARM64 architecture_; maybe put them in same line is better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Availability and compatibility are two different concepts. You can put them in the same line if you want, but I do not agree with using the draft wording.