scanner: add more logs #100
Conversation
We encounter some weird issue that the ID is changed after reboot.
Add these logs would help us to verify easily.
Signed-off-by: Vicente Cheng <[email protected]>
Signed-off-by: Vicente Cheng <[email protected]>
| @@ -98,6 +98,11 @@ func (s *Scanner) collectAllDevices() []*deviceWithAutoProvision { | |||
| logrus.Infof("Skip adding non-identifiable block device /dev/%s", disk.Name) | |||
| continue | |||
| } | |||
| logrus.Infof("Adding the disk with block device /dev/%s, id(Name): %s on node %s", disk.Name, bd.Name, s.NodeName) | |||
There was a problem hiding this comment.
It's already too late now that the PR has been merged, but this question nevertheless.
Does it not make sense to write this information in one line? The output in the log does not always have to look like in the code. In the meantime in which these output lines are written to the log, other messages can also be written. This can make the output quite confusing. Shouldn't logrus.WithFields be used here?
There was a problem hiding this comment.
Yeah, I agree that.
We will use WithFields after introducing the log format.
I thought we had a similar issue with this (for the whole harvester components).
There was a problem hiding this comment.
I thought we had a similar issue with this (for the whole harvester components).
Yes, see here.
There was a problem hiding this comment.
Exactly this one. I would like to refine all the logs when processing this.
|
@Mergifyio backport v0.5.x v0.6.x |
✅ Backports have been created
|
Problem:
We encounter some weird issue that the ID is changed after reboot.
Solution:
Add these logs would help us to verify easily.
Related Issue:
Test plan:
None