[e2e] add configure options for RKE1 and RKE2 #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harvester_e2e_tests/conftest.py
Outdated
| @@ -210,9 +210,21 @@ def pytest_addoption(parser): | |||
| parser.addoption( | |||
| '--kubernetes-version', | |||
| action='store', | |||
| default=config_data.get('kubernetes-version', 'v1.21.6+rke2r1'), | |||
| default=config_data.get('kubernetes-version', 'v1.24.11+rke2r1'), | |||
There was a problem hiding this comment.
Can we just use the value from config.yml and not set a fallback value here? Reason being as below:
- Kubernetes version keeps updating frequently, we'll have overhead of updating the versions at 2 places.
- It is okay to let the test fail if versions are not defined properly in config.yml or we have some problem in parsing config.yml.
- Let these values in the file be consistent with others as we are not putting fallback values for other variables.
khushboo-rancher
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
RKE1-version,RKE2-versionref to #794