Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CY]Ensure requests are intercepted before the page loads #919

Merged
merged 10 commits into from
Aug 28, 2023

Conversation

WuJun2016
Copy link
Contributor

@WuJun2016 WuJun2016 commented Aug 18, 2023

Sometimes it happens that the page is already loaded, but cypress is still in intercept wait, I think this is a potential problem. (I don't have a way to provide a stable reproduction of the steps, it may have something to do with network speed)

image

The solution is to tell cypess which api to intercept before entering the page, in order to avoid Cypress not being able to intercept them even though the API request has already been completed

CI report: https://minio.provo.rancherlabs.com:31524/cypress-test-report/cypress/results/20230827-180209-842d76f9/index.html

@WuJun2016 WuJun2016 changed the title Ensure requests are intercepted before the page loads [CY]Ensure requests are intercepted before the page loads Aug 18, 2023
@WuJun2016 WuJun2016 force-pushed the enhancement branch 2 times, most recently from dcaad8b to 9ae6cb9 Compare August 27, 2023 14:42
Copy link
Contributor

@n313893254 n313893254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@n313893254 n313893254 merged commit f8eed99 into harvester:main Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants