Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: The Java spotless CI code should reformat code to indent 4 spaces rather than 8 #128

Open
mattp-swirldslabs opened this issue Aug 23, 2024 · 1 comment
Open

bug: The Java spotless CI code should reformat code to indent 4 spaces rather than 8 #128

mattp-swirldslabs opened this issue Aug 23, 2024 · 1 comment
Assignees
@mattp-swirldslabs
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Milestone
0.2.0

Comments

@mattp-swirldslabs
Copy link
Contributor

From a recent PR code review:

This is a bug in spotless for services (the original directive was miscommunicated repeatedly) that we should not, in my opinion, replicate.
continuation_indent should be 4, not 8.
The intent for services was to be 4 base and 4 more for continuation, but that was communicated as 8 total and translated to spotless as 8 more.
@mattp-swirldslabs mattp-swirldslabs added Bug A error that causes the feature to behave differently than what was expected based on design docs P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Aug 23, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.1.0 milestone Aug 23, 2024
@mattp-swirldslabs mattp-swirldslabs self-assigned this Aug 23, 2024
@mattp-swirldslabs mattp-swirldslabs mentioned this issue Aug 23, 2024
Merged
2 tasks
@mattp-swirldslabs
Copy link
Contributor Author

mattp-swirldslabs commented Aug 23, 2024 •
edited
Loading

Also from the same PR review. This shows what the before and after should look like when spotless is fixed.

image

@AlfredoG87 AlfredoG87 modified the milestones: 0.1.0, 0.2.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattp-swirldslabs mattp-swirldslabs

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@mattp-swirldslabs @AlfredoG87