Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 00071 hedera protobufs #117

Merged
merged 90 commits into from
Aug 23, 2024
Merged

feat: 00071 hedera protobufs #117

merged 90 commits into from
Aug 23, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Aug 20, 2024

Description:

This PR integrates the official hedera-protobufs types as compiled by PBJ and protoc.

  • Until we have an integration point with Helidon to use use PBJ types internally, we will need a translation layer to convert between protoc types and PBJ types
  • PBJ types are used throughout the block node internal business logic. We only convert protoc -> PBJ and PBJ -> protoc when interacting with Helidon.
  • Adjusted the read and write to use PBJ types
  • Configured gradle to build the hedera-protobufs types in the :stream sub project and export it to :server
  • Added additional unit tests to cover the translation layer

Related issue(s):

Fixes #73
Fixes #70
Fixes #71
Fixes #74

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs self-assigned this Aug 20, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.1.0 milestone Aug 20, 2024
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
stream/build.gradle.kts Outdated Show resolved Hide resolved
jjohannes
jjohannes previously approved these changes Aug 23, 2024
jjohannes
jjohannes previously approved these changes Aug 23, 2024
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progress marker (so github doesn't keep showing 50+ commits as "changes since last review").

@mattp-swirldslabs mattp-swirldslabs merged commit d938806 into main Aug 23, 2024
7 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00071-hedera-protobufs branch August 23, 2024 19:50
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90dd282) to head (3827a83).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #117   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       114       121    +7     
===========================================
  Files             21        21           
  Lines            430       492   +62     
  Branches          25        27    +2     
===========================================
+ Hits             430       492   +62     
Files Coverage Δ
...va/com/hedera/block/server/BlockStreamService.java 100.00% <100.00%> (ø)
...erver/consumer/ConsumerStreamResponseObserver.java 100.00% <100.00%> (ø)
...ock/server/mediator/LiveStreamMediatorBuilder.java 100.00% <ø> (ø)
.../block/server/mediator/LiveStreamMediatorImpl.java 100.00% <100.00%> (ø)
...ra/block/server/persistence/storage/FileUtils.java 100.00% <100.00%> (ø)
.../persistence/storage/PersistenceStorageConfig.java 100.00% <100.00%> (ø)
...ver/persistence/storage/read/BlockAsDirReader.java 100.00% <100.00%> (ø)
...sistence/storage/read/BlockAsDirReaderBuilder.java 100.00% <ø> (ø)
.../persistence/storage/remove/BlockAsDirRemover.java 100.00% <100.00%> (ø)
...er/persistence/storage/write/BlockAsDirWriter.java 100.00% <100.00%> (ø)
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
6 participants