-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dagger refactor #134
Commits on Aug 24, 2024
-
Injecting BlockWriter as part of PersistenInjectionModule
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cedb64d - Browse repository at this point
Copy the full SHA cedb64dView commit details -
Refactoring everything at BlockNodeApp to use Dagger singletons inste…
…ad injected at the constructor by DaggerComponent, instead of initializing them on the startup sequence. Also, adding a BlockNodeApp Test now that everything is being injected. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 31eddb9 - Browse repository at this point
Copy the full SHA 31eddb9View commit details -
Improving test and including missing java docs
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e945fb1 - Browse repository at this point
Copy the full SHA e945fb1View commit details -
bringing back mock needed for test
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58b61a7 - Browse repository at this point
Copy the full SHA 58b61a7View commit details -
started refactor of BlockNodeContextFactory and BlockNodeContext, is …
…working, some tests are failing, but saving this checkpoint before further large scale refactor. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 41db6ca - Browse repository at this point
Copy the full SHA 41db6caView commit details
Commits on Aug 25, 2024
-
Fixed UT for existing tests, ContextFactory is just a Shell, we shoul…
…d be able to get rid of it soon. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f563f3 - Browse repository at this point
Copy the full SHA 3f563f3View commit details -
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a00e0b3 - Browse repository at this point
Copy the full SHA a00e0b3View commit details -
Got rid of the BlockNodeContextFactory, next step, probably for a fut…
…ure PR, is to get Rid of the BlockNodeContext completely. Now that we have Dagger dependencies are cheap, and is better to inject the minimum amount of them, only when in need. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9b69e2 - Browse repository at this point
Copy the full SHA f9b69e2View commit details -
fixed javadocs and exported metrics to remove warning
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 883969c - Browse repository at this point
Copy the full SHA 883969cView commit details -
Refactor BlockNodeAppInjectionComponent to need an external configura…
…tion instead of providing one itself. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 30cda24 - Browse repository at this point
Copy the full SHA 30cda24View commit details -
Moved PersistenceInjectionModule to persistance package instead of pe…
…rsistence.storage Added export metricsService to the module-info Refactored Dagger Component to receive a Configuration from outside. Added UT for MediatorInjectionModule Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99aa01f - Browse repository at this point
Copy the full SHA 99aa01fView commit details -
Added UT for PersistenceInjectionModule
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b2690c - Browse repository at this point
Copy the full SHA 1b2690cView commit details -
Added UT for missing InjectionModules, removed unneeded configuration…
… definition from ConfigExtensions Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 689b6fc - Browse repository at this point
Copy the full SHA 689b6fcView commit details -
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 56af241 - Browse repository at this point
Copy the full SHA 56af241View commit details
Commits on Aug 26, 2024
-
Settling for Factory instead of Builder when passing the configuration
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86ac482 - Browse repository at this point
Copy the full SHA 86ac482View commit details -
Refactored GrpcProvider dagger bean to use the interface instead of t…
…he implementation, to be able to use Bind instead of Provide, deleted unneeded UT. Removed @nonnull annotation from injection module, since is redundant. Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15076c5 - Browse repository at this point
Copy the full SHA 15076c5View commit details
Commits on Aug 27, 2024
-
Moved Application_Properties file to Constants
Signed-off-by: Alfredo Gutierrez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 020dd92 - Browse repository at this point
Copy the full SHA 020dd92View commit details