Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dagger refactor #134

Merged
merged 17 commits into from
Aug 27, 2024
Merged

feat: Dagger refactor #134

merged 17 commits into from
Aug 27, 2024

Commits on Aug 24, 2024

  1. Injecting BlockWriter as part of PersistenInjectionModule 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    cedb64d View commit details
    Browse the repository at this point in the history

  2. Refactoring everything at BlockNodeApp to use Dagger singletons inste… 

    …ad injected at the constructor by DaggerComponent, instead of initializing them on the startup sequence. Also, adding a BlockNodeApp Test now that everything is being injected.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    31eddb9 View commit details
    Browse the repository at this point in the history

  3. Improving test and including missing java docs 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e945fb1 View commit details
    Browse the repository at this point in the history

  4. bringing back mock needed for test 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    58b61a7 View commit details
    Browse the repository at this point in the history

  5. started refactor of BlockNodeContextFactory and BlockNodeContext, is … 

    …working, some tests are failing, but saving this checkpoint before further large scale refactor.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    41db6ca View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Fixed UT for existing tests, ContextFactory is just a Shell, we shoul… 

    …d be able to get rid of it soon.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    3f563f3 View commit details
    Browse the repository at this point in the history

  2. fixing warnings 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    a00e0b3 View commit details
    Browse the repository at this point in the history

  3. Got rid of the BlockNodeContextFactory, next step, probably for a fut… 

    …ure PR, is to get Rid of the BlockNodeContext completely. Now that we have Dagger dependencies are cheap, and is better to inject the minimum amount of them, only when in need.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f9b69e2 View commit details
    Browse the repository at this point in the history

  4. fixed javadocs and exported metrics to remove warning 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    883969c View commit details
    Browse the repository at this point in the history

  5. Refactor BlockNodeAppInjectionComponent to need an external configura… 

    …tion instead of providing one itself.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    30cda24 View commit details
    Browse the repository at this point in the history

  6. Moved PersistenceInjectionModule to persistance package instead of pe… 

    …rsistence.storage

Added export metricsService to the module-info

Refactored Dagger Component to receive a Configuration from outside.

Added UT for MediatorInjectionModule

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    99aa01f View commit details
    Browse the repository at this point in the history

  7. Added UT for PersistenceInjectionModule 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1b2690c View commit details
    Browse the repository at this point in the history

  8. Added UT for missing InjectionModules, removed unneeded configuration… 

    … definition from ConfigExtensions

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    689b6fc View commit details
    Browse the repository at this point in the history

  9. Last UT to complete coverage 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    56af241 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Settling for Factory instead of Builder when passing the configuration 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    86ac482 View commit details
    Browse the repository at this point in the history

  2. Refactored GrpcProvider dagger bean to use the interface instead of t… 

    …he implementation, to be able to use Bind instead of Provide, deleted unneeded UT.

Removed @nonnull annotation from injection module, since is redundant.

Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    15076c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Moved Application_Properties file to Constants 

    Signed-off-by: Alfredo Gutierrez <[email protected]>
    @AlfredoG87
    AlfredoG87 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    020dd92 View commit details
    Browse the repository at this point in the history