refactor: MetricsService refactor to use an interface #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and exposed them using a getter method. Signed-off-by: Alfredo Gutierrez <[email protected]>
… reflect the changes. Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added
the
Improvement
AlfredoG87
added
the
P2
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
previously approved these changes
Aug 27, 2024
server/src/main/java/com/hedera/block/server/metrics/MetricsService.java
Show resolved
Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 132 135 +3
===========================================
Files 26 26
Lines 510 513 +3
Branches 27 27
===========================================
+ Hits 510 513 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
MetricsService refactor to use an interface
Refactor for Dagger DI metricsService
Related issue(s):
Fixes #141
Notes for reviewer:
Checklist