-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add simulator as dependency in Suites #242
Merged
georgi-l95
merged 4 commits into
main
from
190-modify-simulator-entry-point-to-be-flexible-as-test-drive
Oct 10, 2024
Merged
feat: Add simulator as dependency in Suites #242
georgi-l95
merged 4 commits into
main
from
190-modify-simulator-entry-point-to-be-flexible-as-test-drive
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
added
Tests
issue related to enhancing the tests
Simulator
Issue related to Block Stream Simulator
labels
Oct 10, 2024
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
This was referenced Oct 10, 2024
Signed-off-by: georgi-l95 <[email protected]>
mattp-swirldslabs
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I had a couple of questions.
...lator/src/main/java/com/hedera/block/simulator/exception/BlockSimulatorParsingException.java
Show resolved
Hide resolved
georgi-l95
deleted the
190-modify-simulator-entry-point-to-be-flexible-as-test-drive
branch
October 10, 2024 21:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=========================================
Coverage 99.66% 99.66%
- Complexity 247 248 +1
=========================================
Files 50 51 +1
Lines 903 907 +4
Branches 61 61
=========================================
+ Hits 900 904 +4
Misses 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes the neccessery changes to add Simulator as dependency in the suites.
Related issue(s):
Fixes #190
Fixes #191
Notes for reviewer:
Checklist