Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add simulator as dependency in Suites #242

Merged

Conversation

georgi-l95
Copy link
Contributor

@georgi-l95 georgi-l95 commented Oct 10, 2024

Description:
This PR makes the neccessery changes to add Simulator as dependency in the suites.

  • Makes the neccessery gradle file changes to export the simulator.
  • Adding new custom exception for parsing to avoid adding more unneeded depdencies.
  • Making isRunning atomic, to set the ground for future of the simulator and handling from different threads.
  • Adds default configuration for it, inside the BaseSuite.java
  • Adds positive test template for data persistence, where the actual work between both will be tested.
  • Adds sample data to be used as resource in future tests.

Related issue(s):

Fixes #190
Fixes #191

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 added Tests issue related to enhancing the tests Simulator Issue related to Block Stream Simulator labels Oct 10, 2024
@georgi-l95 georgi-l95 added this to the 0.1.0 milestone Oct 10, 2024
@georgi-l95 georgi-l95 self-assigned this Oct 10, 2024
@georgi-l95 georgi-l95 requested a review from a team as a code owner October 10, 2024 08:50
Signed-off-by: georgi-l95 <[email protected]>
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I had a couple of questions.

@georgi-l95 georgi-l95 merged commit 3a565f3 into main Oct 10, 2024
13 checks passed
@georgi-l95 georgi-l95 deleted the 190-modify-simulator-entry-point-to-be-flexible-as-test-drive branch October 10, 2024 21:59
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (d55321f) to head (0e666b8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #242   +/-   ##
=========================================
  Coverage     99.66%   99.66%           
- Complexity      247      248    +1     
=========================================
  Files            50       51    +1     
  Lines           903      907    +4     
  Branches         61       61           
=========================================
+ Hits            900      904    +4     
  Misses            3        3           
Files with missing lines Coverage Δ
...edera/block/simulator/BlockStreamSimulatorApp.java 100.00% <100.00%> (ø)
...ator/exception/BlockSimulatorParsingException.java 100.00% <100.00%> (ø)
.../simulator/generator/BlockAsFileLargeDataSets.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simulator Issue related to Block Stream Simulator Tests issue related to enhancing the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wire Simulator with Test Infrastructure Modify Simulator entry point to be flexible as test driver
2 participants