refactor: introduce commons module #251
Merged
Commits on Oct 15, 2024
-
introduce the common module, abstract some literals
Signed-off-by: Atanas Atanasov <[email protected]>
-
abstract logic from existing utility classes
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
Signed-off-by: Atanas Atanasov <[email protected]>
-
address pr comments based on new agreements
Signed-off-by: Atanas Atanasov <[email protected]>
Commits on Oct 16, 2024
-
Addressed review and other items
* Fixed todo item by overloading method and moving default to local constant * Fixed some formatting issues * Fixed string utility to match more typical conventions * Modified "default" file permissions to not make everything executable * Renamed "abbreviated" classes to use full names * Renamed unsafe file methods to add "Unsafe" at the end * Documented why "unsafe" methods are not safe for production use * General cleanup Fixed a build headache * Modified spotless conventions to remove javadoc formatting for now * This was creating issues and conflicts between different tools; we'll need to add a proper _separate_ javadoc format once we can figure out how to do so within the ultra-strict spotless "write a new plugin" approach. Signed-off-by: Joseph Sinclair <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.