-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce commons module #251
Merged
Merged
Commits on Oct 15, 2024
-
introduce the common module, abstract some literals
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46969a5 - Browse repository at this point
Copy the full SHA 46969a5View commit details -
abstract logic from existing utility classes
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea0d11b - Browse repository at this point
Copy the full SHA ea0d11bView commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bd7798f - Browse repository at this point
Copy the full SHA bd7798fView commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 887e763 - Browse repository at this point
Copy the full SHA 887e763View commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1c9160 - Browse repository at this point
Copy the full SHA e1c9160View commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 764bfc4 - Browse repository at this point
Copy the full SHA 764bfc4View commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bbfba2 - Browse repository at this point
Copy the full SHA 6bbfba2View commit details -
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0f09e9 - Browse repository at this point
Copy the full SHA b0f09e9View commit details -
address pr comments based on new agreements
Signed-off-by: Atanas Atanasov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d3475b - Browse repository at this point
Copy the full SHA 0d3475bView commit details
Commits on Oct 16, 2024
-
Addressed review and other items
* Fixed todo item by overloading method and moving default to local constant * Fixed some formatting issues * Fixed string utility to match more typical conventions * Modified "default" file permissions to not make everything executable * Renamed "abbreviated" classes to use full names * Renamed unsafe file methods to add "Unsafe" at the end * Documented why "unsafe" methods are not safe for production use * General cleanup Fixed a build headache * Modified spotless conventions to remove javadoc formatting for now * This was creating issues and conflicts between different tools; we'll need to add a proper _separate_ javadoc format once we can figure out how to do so within the ultra-strict spotless "write a new plugin" approach. Signed-off-by: Joseph Sinclair <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a1723d2 - Browse repository at this point
Copy the full SHA a1723d2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.