Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a protocol document for publishBlockStream #267

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

jsync-swirlds
Copy link
Member

  • Added a new document in docs/Protocol for publishBlockStream.
  • Included a first pass protocol definition.
    • Note this is in general informal language; not Estelle, SDL, LOTOS,
      or other highly formal language.

Fixes #120

@jsync-swirlds jsync-swirlds added Block Node Issues/PR related to the Block Node. Documentation Issues/PR related to documentation labels Oct 16, 2024
@jsync-swirlds jsync-swirlds added this to the 0.2.0 milestone Oct 16, 2024
@jsync-swirlds jsync-swirlds self-assigned this Oct 16, 2024
@jsync-swirlds jsync-swirlds changed the title Add a protocol document for publishBlockStream. docs: Add a protocol document for publishBlockStream Oct 16, 2024
@jsync-swirlds jsync-swirlds marked this pull request as ready for review October 16, 2024 21:22
@jsync-swirlds jsync-swirlds requested a review from a team as a code owner October 16, 2024 21:22
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I've already reviewed the design, so don't have any comments on it. Left a few formatting suggestions.

docs/Protocol/publishBlockStream.md Outdated Show resolved Hide resolved
docs/Protocol/publishBlockStream.md Outdated Show resolved Hide resolved
docs/Protocol/publishBlockStream.md Show resolved Hide resolved
docs/Protocol/publishBlockStream.md Show resolved Hide resolved
jsync-swirlds and others added 2 commits October 17, 2024 15:14
* Added a new document in `docs/Protocol` for `publishBlockStream`.
* Included a first pass protocol definition.
   * Note this is in general informal language; not Estelle, SDL, LOTOS,
     or other highly formal language.

Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
@jsync-swirlds jsync-swirlds force-pushed the add-handshake-document branch 3 times, most recently from dfc7cc7 to 5e58a32 Compare October 18, 2024 00:11
* Changed definition list to work within github limitations.
* Added an Abstract section to reduce confusion.
* Added a readme file to describe items in the protocol folder
* Added a reliability note to explain the cautious nature of the
  protocol.

Signed-off-by: Joseph Sinclair <[email protected]>
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm, looks good 🚀

@jsync-swirlds jsync-swirlds merged commit d4d8a6e into main Oct 18, 2024
13 checks passed
@jsync-swirlds jsync-swirlds deleted the add-handshake-document branch October 18, 2024 16:31
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (c0ce015) to head (9ffb8e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #267   +/-   ##
=========================================
  Coverage     99.78%   99.78%           
  Complexity      259      259           
=========================================
  Files            52       52           
  Lines           938      938           
  Branches         64       64           
=========================================
  Hits            936      936           
  Misses            2        2           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Documentation Issues/PR related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design handshake between CN and BN to determine what Block to start streaming from.
3 participants