Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements ChunkUtils #289

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Oct 22, 2024

Description:

  • feedback left on previous PR that was pending

Related issue(s):

Fixes #288

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Oct 22, 2024
@AlfredoG87 AlfredoG87 added Block Node Issues/PR related to the Block Node. Simulator Issue related to Block Stream Simulator Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. Phase 1 Issue/PR related to Phase 1 labels Oct 22, 2024
@AlfredoG87 AlfredoG87 added this to the 0.2.0 milestone Oct 22, 2024
@AlfredoG87 AlfredoG87 changed the title fix: Latest Changes to protobufs feat: Latest Changes to protobufs Oct 22, 2024
- Improved variable name on ConsumerStreamResponseObserver

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 changed the title feat: Latest Changes to protobufs feat: Improvements ChunkUtils Oct 23, 2024
@AlfredoG87 AlfredoG87 marked this pull request as ready for review October 23, 2024 21:40
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner October 23, 2024 21:40
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlfredoG87 AlfredoG87 merged commit 8d10540 into main Oct 24, 2024
18 checks passed
@AlfredoG87 AlfredoG87 deleted the repeated-block-items-improvements branch October 24, 2024 00:16
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (4fb471c) to head (c87905c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #289   +/-   ##
=========================================
  Coverage     99.62%   99.62%           
+ Complexity      290      288    -2     
=========================================
  Files            57       57           
  Lines          1060     1060           
  Branches         77       78    +1     
=========================================
  Hits           1056     1056           
  Misses            3        3           
  Partials          1        1           
Files with missing lines Coverage Δ
...java/com/hedera/block/common/utils/ChunkUtils.java 100.00% <100.00%> (ø)
...erver/consumer/ConsumerStreamResponseObserver.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. Phase 1 Issue/PR related to Phase 1 Simulator Issue related to Block Stream Simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements pending from Repeated BlockItems PR Review
3 participants