Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add a new gradle task to start the docker container in debug mode. #57

Merged
merged 2 commits into from
Jul 30, 2024
Merged

build: Add a new gradle task to start the docker container in debug mode. #57

merged 2 commits into from
Jul 30, 2024

Conversation

AlfredoG87
Copy link
Contributor

Description:
Add a new gradle task to start the docker container in debug mode.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 requested a review from a team as a code owner July 27, 2024 22:48
@AlfredoG87 AlfredoG87 self-assigned this Jul 27, 2024
@AlfredoG87 AlfredoG87 added the Improvement Code changes driven by non business requirements label Jul 27, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Jul 27, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (726e798) to head (7e1aa5d).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main      #57   +/-   ##
=========================================
  Coverage     54.33%   54.33%           
  Complexity       25       25           
=========================================
  Files             7        7           
  Lines           173      173           
  Branches          6        6           
=========================================
  Hits             94       94           
  Misses           75       75           
  Partials          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlfredoG87 AlfredoG87 changed the title Add a new gradle task to start the docker container in debug mode. build: Add a new gradle task to start the docker container in debug mode. Jul 29, 2024
mattp-swirldslabs
mattp-swirldslabs reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a gradle task to trigger the debug flow

server/docker/update-env.sh Show resolved Hide resolved
@AlfredoG87 AlfredoG87 force-pushed the docker-debug-container branch 2 times, most recently from 3117a21 to bb6ec2f Compare July 30, 2024 02:26
@AlfredoG87
Adding Debug Container to the Docker Gradle tasks
7328e69 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
style fixes
7e1aa5d 
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
mattp-swirldslabs approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 merged commit fda4418 into main Jul 30, 2024
6 checks passed
@AlfredoG87 AlfredoG87 deleted the docker-debug-container branch July 30, 2024 16:38
@AlfredoG87 AlfredoG87 mentioned this pull request Jul 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

Assignees

@AlfredoG87 AlfredoG87

Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlfredoG87 @mattp-swirldslabs