Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Helm Chart #63

Merged
merged 4 commits into from
Jul 31, 2024
Merged

feat: Helm Chart #63

merged 4 commits into from
Jul 31, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Jul 30, 2024 •
edited
Loading

Description:

  • Initial Helm Charts for deploying Block Node into a K8 Cluster
  • GHA WF for Helm Charts Test

Related issue(s):

Fixes #54

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Jul 30, 2024
@AlfredoG87 AlfredoG87 added Release Issues tied to release management functions github_actions P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Jul 30, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (312cad5) to head (e22296a).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main      #63   +/-   ##
=========================================
  Coverage     54.33%   54.33%           
  Complexity       25       25           
=========================================
  Files             7        7           
  Lines           173      173           
  Branches          6        6           
=========================================
  Hits             94       94           
  Misses           75       75           
  Partials          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlfredoG87 AlfredoG87 changed the title Initial set of templates for Block Node server k8 Helm Chart feat: Helm Chart Jul 30, 2024
@AlfredoG87
improving the generation of configmap and secret files, also cleaned …
b9d438a 
…unneeded files and improved README.md documentation.

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 marked this pull request as ready for review July 31, 2024 03:26
@AlfredoG87 AlfredoG87 requested review from a team as code owners July 31, 2024 03:26
mattp-swirldslabs
mattp-swirldslabs approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 merged commit 926b34c into main Jul 31, 2024
16 checks passed
@AlfredoG87 AlfredoG87 deleted the helm-charts branch July 31, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

@nathanklick nathanklick Awaiting requested review from nathanklick

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL

Assignees

@AlfredoG87 AlfredoG87

Labels
github_actions P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Release Issues tied to release management functions
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Helm Charts for deploying the BN Server App using the Image on a K8 Cluster
3 participants
@AlfredoG87 @JeffreyDallas @mattp-swirldslabs