Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create hip-1021 #1021

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kantorcodes
Copy link
Contributor

Description

This pull request introduces HIP-1021, titled "Improve Assignment of Auto-Renew Account ID for Topics." The proposal aims to enhance the Hedera Consensus Service (HCS) by automating the assignment of the autoRenewAccountId to the account that creates a TopicCreateTransaction. This feature is particularly useful when an Admin Key is not present during topic creation, ensuring that the auto-renewal mechanism is consistently applied.

The key changes include:

  • Automatic Assignment: The autoRenewAccountId will automatically be set to the payer_account_id of the transaction if an Admin Key is not provided during topic creation.
  • Retroactive Application: For existing topics that have only a Submit Key and no autoRenewAccountId, the original payer_account_id will be retroactively set as the autoRenewAccountId.
  • Consistency and Error Reduction: This change aims to prevent user errors and ensure consistent management of topic renewals.

Improvements

  1. Automatic Setting of Renewal Account:

    • The account that creates a topic will now automatically be used for renewals. Users don't need to manually set this anymore, making the process simpler and reducing the chance of mistakes.
  2. Uniform Handling of Old Topics:

    • For older topics without a set renewal account, the system will automatically use the original account that created them for rent. This makes renewals consistent across all topics.
  3. Fewer Mistakes:

    • By automating the setup of the renewal account, there’s a lower risk of topics accidentally expiring due to missing settings.
  4. Easier for Users:

    • Users no longer need to worry about setting up renewal accounts; the system handles it automatically, making the overall process more user-friendly.
  5. Ready for Future Changes:

    • This change also prepares the system for potential future updates, like introducing rent for topics, ensuring everything is correctly configured in advance.

Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit b1220b4
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/66ab78ba2541840008f1b5cd
😎 Deploy Preview https://deploy-preview-1021--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


This HIP proposes a modification to the Hedera Consensus Service (HCS) to:
- Enable setting the `autoRenewAccountId` to the account creating a `TopicCreateTransaction` when an Admin Key is not present during Topic Creation.
- It ensures that for all existing topics with only a Submit Key and no `autoRenewAccountId`, the original `payer_account_id` of the topic is retroactively set as the `autoRenewAccountId`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not modify existing topics IMO:

  • We usually do not modify existing entities. A user may have left autoRenewAccount empty intentionally and disagrees with this change.
  • This would have to be initiated outside of the consensus node because the consensus node does not store the original payer_account_id.
  • It is unclear who should pay for these transactions.

This HIP proposes a modification to the Hedera Consensus Service (HCS) to:
- Enable setting the `autoRenewAccountId` to the account creating a `TopicCreateTransaction` when an Admin Key is not present during Topic Creation.
- It ensures that for all existing topics with only a Submit Key and no `autoRenewAccountId`, the original `payer_account_id` of the topic is retroactively set as the `autoRenewAccountId`.
- Automatically set the `autoRenewAccountId` to the `payer_account_id` of the Topic Id to prevent unintended user error.
Copy link
Contributor

@netopyr netopyr Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I be able to leave this field empty intentionally?
Another solution could be to set this as a default in the SDKs. This would give me a similar experience, but I would still be able to clear the autoRenewAccountId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants