HIP-980: Add shadow fork support as a rejected idea #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
…al into hip-xxx-extend-apis-with-timestamp # Conflicts: # HIP/hip-980.md Signed-off-by: IvanKavaldzhiev <[email protected]>
…al into hip-xxx-extend-apis-with-timestamp
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nana-EC
reviewed
Oct 21, 2024
| @@ -11,55 +11,67 @@ last-call-date-time: 2024-07-23T07:00:00Z | |||
| created: 2024-06-03 | |||
| requested-by: Solo Labs | |||
| discussions-to: https://github.com/hashgraph/hedera-improvement-proposal/discussions/981 | |||
| updated: 2024-08-16 | |||
| updated: 2024-10-09 | |||
There was a problem hiding this comment.
@mgarbs and @steven-sheehy should we be updating the Status to be Rejected?
| This change will be especially valuable for building the foundation of the so-called shadow fork functionality, where a user or developer can use a local mirror node instance but run it against a production environment state. | ||
| Having this support, users or developers will have the ability to use public state data to simulate and troubleshoot existing issues or replay historical transactions using local mirror node instance against production state. | ||
| To enhance user experience and allow users or developers to query the state of an entity at a specific point in time we | ||
| will add a timestamp query parameter to all of the entity-based REST APIs that currently don't have one. |
There was a problem hiding this comment.
Q: why was the motivation section cut from 3 points to 1?
Seems strange for motivation to have changed now.
There was a problem hiding this comment.
It's because the shadow fork initiative is being rejected in this HIP. Most of the points in the motivation section were describing the motivation of having shadow fork functionality. If we remove this part of the section what is left is the extension of reading historical data for all entity types via the REST API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After analyzing the efforts for implementing HIP-980, it was proposed to move the idea of shadow fork support in mirror-node as a rejected idea. That is, because it would have introduced too much REST API calls against public mirror node instances and would harm the performance. In addition, the UX would have included more efforts from a user perspective and wouldn't have been so easy to use.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist