Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich staking metadata exports #786

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Enrich staking metadata exports #786

merged 10 commits into from
Aug 14, 2023

Conversation

tinker-michaelj
Copy link
Contributor

Description:

  • Proposes to make the ingredients of the HIP-782 reward rate formula easily available to mirror nodes.

@tinker-michaelj
Add reserved rewards export HIP
7920a03 
Signed-off-by: Michael Tinker <[email protected]>
@netlify
Copy link

netlify bot commented Aug 10, 2023 •
edited
Loading

✅ Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 99c7678
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/64d6a53088c91a000836ff06
😎 Deploy Preview https://deploy-preview-786--hedera-hips.netlify.app/hip/hip-786
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rbair23
rbair23 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@rbair23 rbair23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use snake_case for mirror node APIs? Otherwise, the HIP looks great!

steven-sheehy
steven-sheehy previously approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we use snake_case for mirror node APIs?

Yep

@tinker-michaelj
Cleanup
6bf209e 
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj
spotless
4aaabb9 
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj
spotless
99c7678 
Signed-off-by: Michael Tinker <[email protected]>
@mgarbs mgarbs merged commit f89b8d3 into hashgraph:main Aug 14, 2023
6 checks passed
kimbor pushed a commit to kimbor/hedera-improvement-proposal that referenced this pull request Jun 24, 2024
@tinker-michaelj @mgarbs @kimbor
Enrich staking metadata exports (hashgraph#786)
5125b40 
Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Michael Garber <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbair23 rbair23 rbair23 approved these changes

@mgarbs mgarbs mgarbs approved these changes

@steven-sheehy steven-sheehy steven-sheehy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinker-michaelj @rbair23 @steven-sheehy @mgarbs