Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Implement custom LRU cache with protected keys #3097
chore: Implement custom LRU cache with protected keys #3097
Changes from 7 commits
bd1b324
1aea374
231d379
f69528d
3a48fee
5640bd3
5ef9848
fc1ef14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 127 in packages/relay/src/lib/clients/cache/impl/customLRUCache.ts
Codecov / codecov/patch
packages/relay/src/lib/clients/cache/impl/customLRUCache.ts#L127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This should work since we're working with fixed length keys. In general I would try to get an exact match, in the case that a key contains the substring of another key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally done here, because we want to also match the
amountSpent
andspendingHistory
keys which contain the${HbarSpendingPlanRepository.collectionKey}:${plan.id}
prefix:${HbarSpendingPlanRepository.collectionKey}:${plan.id}:amountSpent
${HbarSpendingPlanRepository.collectionKey}:${plan.id}:spendingHistory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to a more general approach where we initialize a set of protected keys in the constructor and then in
delete
we check for the existence of the key in this set of protected keys: