Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updaiting workflow permissions and adding hardend runner per step-security. #3124

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Oct 18, 2024

Description:
Updating several workflows and their permissions per step-security requirements and adding hardend runner to one of the workflows.

Related issue(s):

Fixes #3121

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est added this to the 0.59.0 milestone Oct 18, 2024
@san-est san-est self-assigned this Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 31,841.9 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.46 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 348.16 KB
  • Total Available Size: increased with 1.56 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.43 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 1.84 MB
    • Space Used Size: increased with 2.08 MB
    • Space Available Size: decreased with 2.27 MB
    • Physical Space Size: increased with 1.84 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

github-actions bot commented Oct 18, 2024

Tests

       3 files     399 suites   18s ⏱️
1 433 tests 1 432 ✔️ 1 💤 0
1 442 runs  1 441 ✔️ 1 💤 0

Results for commit b89ff2d.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

Acceptance Tests

  17 files  245 suites   28m 2s ⏱️
599 tests 593 ✔️ 4 💤 2
728 runs  722 ✔️ 4 💤 2

Results for commit b89ff2d.

♻️ This comment has been updated with latest results.

.github/workflows/pr-label-milestone-check.yml Outdated Show resolved Hide resolved
.github/workflows/conformity-workflow.yml Outdated Show resolved Hide resolved
.github/workflows/release-acceptance.yml Outdated Show resolved Hide resolved
san-est and others added 2 commits October 21, 2024 11:32
@san-est san-est requested a review from a team as a code owner October 21, 2024 08:44
Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (daf2aef) to head (b89ff2d).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   83.19%   85.46%   +2.26%     
==========================================
  Files          63       66       +3     
  Lines        4242     4402     +160     
  Branches      830      868      +38     
==========================================
+ Hits         3529     3762     +233     
+ Misses        470      378      -92     
- Partials      243      262      +19     
Flag Coverage Δ
relay 85.59% <ø> (ø)
server 83.48% <ø> (ø)
ws-server 36.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

@Nana-EC
Copy link
Collaborator

Nana-EC commented Oct 25, 2024

@san-est need to fix DCO then you can check in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default GITHUB_TOKEN permissions per step-security recommendations
4 participants