Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: (deps) [Snyk] Upgrade ethers from 6.13.2 to 6.13.3 #3149

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

swirlds-automation
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to upgrade ethers from 6.13.2 to 6.13.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released on 22 days ago.

Release notes
Package name: ethers from ethers GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Copy link

github-actions bot commented Oct 23, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 25,731.3 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.46 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 348.16 KB
  • Total Available Size: decreased with 13.65 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.45 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 1.84 MB
    • Space Used Size: increased with 2.06 MB
    • Space Available Size: decreased with 16.47 MB
    • Physical Space Size: increased with 1.84 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

Acceptance Tests

     26 files     363 suites   41m 16s ⏱️
   602 tests    579 ✔️ 4 💤 19
1 155 runs  1 126 ✔️ 6 💤 23

Results for commit 2abbb94.

Snyk has created this PR to upgrade ethers from 6.13.2 to 6.13.3.

See this package in npm:
ethers

See this project in Snyk:
https://app.snyk.io/org/json-rpc-relay/project/4c142326-fa3c-4252-9c35-19efc13dae91?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: ebadiere <[email protected]>
@ebadiere ebadiere force-pushed the snyk-upgrade-1e89b566cb837d9360a321015f40c02f branch from 2abbb94 to b287132 Compare October 23, 2024 13:50
Copy link

sonarcloud bot commented Oct 23, 2024

@ebadiere ebadiere changed the title [Snyk] Upgrade ethers from 6.13.2 to 6.13.3 build (deps):[Snyk] Upgrade ethers from 6.13.2 to 6.13.3 Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

Test Results

 17 files  ± 0  245 suites  +17   28m 56s ⏱️ - 2m 23s
600 tests + 1  595 ✅ + 1  4 💤 ±0  1 ❌ ±0 
702 runs  +79  697 ✅ +79  4 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit b287132. ± Comparison against base commit 1ad7040.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node added enhancement New feature or request dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Oct 23, 2024
@quiet-node quiet-node added this to the 0.59.0 milestone Oct 23, 2024
@ebadiere ebadiere changed the title build (deps):[Snyk] Upgrade ethers from 6.13.2 to 6.13.3 build(deps):[Snyk] Upgrade ethers from 6.13.2 to 6.13.3 Oct 23, 2024
@ebadiere ebadiere changed the title build(deps):[Snyk] Upgrade ethers from 6.13.2 to 6.13.3 build: (deps) [Snyk] Upgrade ethers from 6.13.2 to 6.13.3 Oct 23, 2024
@ebadiere ebadiere merged commit b4bc10d into main Oct 23, 2024
47 of 53 checks passed
@ebadiere ebadiere deleted the snyk-upgrade-1e89b566cb837d9360a321015f40c02f branch October 23, 2024 14:57
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (4ab3666) to head (b287132).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3149   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files          66       66           
  Lines        4250     4250           
  Branches      828      828           
=======================================
  Hits         3536     3536           
  Misses        472      472           
  Partials      242      242           
Flag Coverage Δ
config-service 100.00% <ø> (ø)
relay 85.36% <ø> (ø)
server 83.52% <ø> (ø)
ws-server 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants