Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: page views now use PageFrame as their top component #1552

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

ericleponner
Copy link
Collaborator

Changes below:

  1. introduce a new PageFrame view
  2. add PageFrame as the top component of the all the page views
  3. move TopNavBar as a child of PageFrame
  4. adapt unit tests

Related issue(s):

Fixes #1551

Notes for reviewer:
No semantic change. Only refactoring.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Dec 10, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.17% 24945 / 33629
🔵 Statements 74.17% 24945 / 33629
🔵 Functions 57.93% 956 / 1650
🔵 Branches 83.08% 4554 / 5481
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/App.vue 71.87% 54.54% 0% 71.87% 89, 99-100, 109-112, 125-126, 144-146, 149-151, 153-158, 161, 164-168
src/components/page/PageFrame.vue 100% 100% 100% 100%
src/pages/AccountDetails.vue 39.13% 79.27% 0% 39.13% 1, 27-29, 31-33, 35-40, 42-51, 53-54, 57-62, 64-87, 89-94, 96-108, 110-114, 117-120, 122-127, 130-131, 133-136, 138-139, 141-142, 145-150, 152, 154-156, 158-170, 172, 174-180, 182-186, 188-192, 194-197, 199, 201-204, 206, 208-211, 213-214, 216-217, 219-225, 227-228, 230-231, 233-238, 240-242, 244-248, 250-252, 254, 257-261, 263-267, 269, 271-274, 276, 278, 280, 282-284, 286-306, 308-314, 316-318, 320-328, 330, 429-435, 438-439, 441, 484-485, 490-491, 508-510
src/pages/Accounts.vue 100% 83.33% 100% 100%
src/pages/AccountsWithKey.vue 73.46% 100% 0% 73.46% 80-82, 87-90, 92-97
src/pages/AdminKeyDetails.vue 100% 81.81% 100% 100%
src/pages/BlockDetails.vue 95.74% 92.5% 20% 95.74% 191-193, 195-197
src/pages/Blocks.vue 100% 83.33% 100% 100%
src/pages/ContractDetails.vue 100% 91.57% 100% 100%
src/pages/Contracts.vue 92.75% 50% 50% 92.75% 38, 47, 49-51
src/pages/MainDashboard.vue 94.44% 100% 100% 94.44% 158-163
src/pages/MobileMenu.vue 100% 100% 100% 100%
src/pages/MobileSearch.vue 32.89% 100% 0% 32.89% 64-67, 69-74, 76-93, 95-105, 107-118
src/pages/NftDetails.vue 92.85% 85.96% 33.33% 92.85% 255, 287, 290-291, 296, 335-341, 369-377
src/pages/NodeDetails.vue 97.58% 83.33% 100% 97.58% 1, 40-43, 293
src/pages/Nodes.vue 99.21% 82.35% 100% 99.21% 1
src/pages/PageNotFound.vue 100% 100% 100% 100%
src/pages/RoutingSpec.vue 20.56% 100% 0% 20.56% 86-88, 90, 92-250, 253-259
src/pages/SearchHelp.vue 100% 100% 100% 100%
src/pages/Staking.vue 51.03% 100% 0% 51.03% 276-280, 282, 284-294, 296, 301-303, 305-307, 309-319, 321-325, 327-330, 332, 334-343, 345-347, 353-355, 361, 363-369, 371-373, 375-381, 383-385, 387, 389, 391-402, 404-408, 410, 412-425, 427-430, 432, 434-435, 437-448, 450-451, 456-459, 464-468, 470-513
src/pages/TokenDetails.vue 97.73% 97.22% 66.66% 97.73% 445, 478-483, 518-519
src/pages/Tokens.vue 100% 87.5% 100% 100%
src/pages/TokensByAccount.vue 80% 100% 0% 80% 67-73
src/pages/TokensByName.vue 82.5% 100% 0% 82.5% 76-77, 80-84
src/pages/TokensByPopularity.vue 82.5% 100% 0% 82.5% 76-77, 80-84
src/pages/TopicDetails.vue 97.22% 84.48% 100% 97.22% 41, 221-222, 226
src/pages/Topics.vue 98.18% 83.33% 100% 98.18% 93
src/pages/TransactionDetails.vue 99% 94.36% 50% 99% 1, 389, 459-460
src/pages/Transactions.vue 100% 100% 50% 100%
src/pages/TransactionsById.vue 62.74% 100% 0% 62.74% 75-76, 78-80, 82-84, 86-88, 90, 92-98
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
Generated in workflow #1517

svienot
svienot previously approved these changes Dec 11, 2024
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ericleponner ericleponner merged commit e134132 into main Dec 11, 2024
7 of 9 checks passed
@ericleponner ericleponner deleted the page_frame branch December 11, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor page views using a common component PageFrame
2 participants