Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily disable KNS test in SearchBar.cy.ts. #1556

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Change below temporarily disable e2e test related to KNS in SearchBar.cy.ts.
This test regularly fails because on KNS deployment issue and pollutes PR review checks.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.17% 24943 / 33629
🔵 Statements 74.17% 24943 / 33629
🔵 Functions 57.93% 956 / 1650
🔵 Branches 83.06% 4548 / 5475
File CoverageNo changed files found.
Generated in workflow #1521

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svienot svienot merged commit 81d4e82 into main Dec 11, 2024
9 checks passed
@svienot svienot deleted the chore_ignore_kns_in_unit_test branch December 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants