Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: label account 0.0.801 as the node reward account #1564

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: label account 0.0.801 as the node reward account #1564

merged 2 commits into from
Dec 13, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 13, 2024

Description:

With these trivial changes:

  • account 801 is identified as Node reward account in the transfer graphs
  • transfers to 801 are treated as fees similar to the transfers to 800

Related issue(s):

Fixes #1562

Notes for reviewer:

Before:
Screenshot 2024-12-13 at 10 08 31

After:
Screenshot 2024-12-13 at 10 08 08

@svienot
Identify account 801 as 'Node reward account' in the transfers and tr…
0a9e5e6 
…eat those fees like 800 account fees.

Signed-off-by: Simon Viénot <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.09% 24866 / 33561
🔵 Statements 74.09% 24866 / 33561
🔵 Functions 57.65% 945 / 1639
🔵 Branches 82.95% 4521 / 5450
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/schemas/MirrorNodeUtils.ts 62.01% 73.63% 72.97% 62.01% 55-56, 62-63, 71-72, 79-80, 97-98, 112-114, 121-122, 132-135, 145-148, 153-154, 198-207, 209-210, 216-217, 260-268, 277-285, 288-296, 348-349, 351-363, 365-366, 368-396, 413-414, 416-427, 429-430, 436-443, 451-458, 466-473, 477-490
src/utils/EntityID.ts 85.33% 98.61% 81.25% 85.33% 127-128, 134-135, 138-145, 171-180
Generated in workflow #1526

ericleponner
ericleponner previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot marked this pull request as ready for review December 13, 2024 09:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

ericleponner
ericleponner approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ericleponner ericleponner merged commit ec5967b into main Dec 13, 2024
8 of 9 checks passed
@ericleponner ericleponner deleted the 1562-label-node-reward-account branch December 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label account 0.0.801 as the node reward account
2 participants
@svienot @ericleponner