Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement generics in Transaction.go #1089

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Oct 2, 2024

Description:

https://www.notion.so/limechain/Go-SDK-refactor-v2-10610baa8dcd80d7a787d086a3ef3181

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 88.04143% with 127 lines in your changes missing coverage. Please review.

Project coverage is 74.22%. Comparing base (13aa1c2) to head (324dbdd).

Files with missing lines Patch % Lines
freeze_transaction.go 0.00% 22 Missing ⚠️
prng_transaction.go 0.00% 19 Missing ⚠️
token_pause_transaction.go 57.89% 8 Missing ⚠️
ethereum_transaction.go 78.94% 4 Missing ⚠️
topic_message_submit_transaction.go 93.33% 3 Missing and 1 partial ⚠️
node_create_transaction.go 84.21% 3 Missing ⚠️
node_update_transaction.go 84.21% 3 Missing ⚠️
token_airdrop_transaction.go 83.33% 3 Missing ⚠️
token_cancel_airdrop_transaction.go 83.33% 3 Missing ⚠️
token_claim_airdrop_transaction.go 83.33% 3 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   72.18%   74.22%   +2.04%     
==========================================
  Files         174      174              
  Lines       28743    21597    -7146     
==========================================
- Hits        20747    16030    -4717     
+ Misses       7251     4899    -2352     
+ Partials      745      668      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crypto.go Show resolved Hide resolved
file_append_transaction.go Show resolved Hide resolved
transaction.go Show resolved Hide resolved
transaction.go Outdated Show resolved Hide resolved
@0xivanov 0xivanov marked this pull request as ready for review October 24, 2024 11:53
@0xivanov 0xivanov requested review from a team as code owners October 24, 2024 11:53
Copy link

sonarcloud bot commented Oct 24, 2024

Copy link
Contributor Author

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until we've release v2.49

@0xivanov 0xivanov changed the title refactor(wip): Implement generics in Transaction.go refactor: Implement generics in Transaction.go Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant