feat: create new account helper function #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
|
Still working on it. I will tag you once I'm done |
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
|
You can check it now @0xivanov |
|
Can you also check this out too: |
|
Thanks for calling my attention, @samswag. I didn't see the comment before. |
0xivanov
reviewed
Oct 8, 2024
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
fixed |
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
|
@Mujhtech try running the following commands to verify the build: |
Yeah, done and fix in the last commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 73.37% 73.42% +0.04%
==========================================
Files 174 174
Lines 24997 24997
==========================================
+ Hits 18342 18353 +11
+ Misses 5909 5898 -11
Partials 746 746 ☔ View full report in Codecov by Sentry. |
|
0xivanov
approved these changes
Oct 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request refactors the account helper functions in the codebase. It introduces a new helper function for creating a new account and removes the old account helper function. The refactoring also includes replacing the old account helper function with the new one in relevant parts of the code.
Related issue(s):
Fixes #1052
Notes for reviewer:
Checklist