-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new account helper function #1097
feat: create new account helper function #1097
Conversation
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Still working on it. I will tag you once I'm done |
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
You can check it now @0xivanov |
Can you also check this out too: |
Thanks for calling my attention, @samswag. I didn't see the comment before. |
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test build is failing.
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
fixed |
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
Signed-off-by: Muhideen Mujeeb Adeoye <[email protected]>
@Mujhtech try running the following commands to verify the build:
|
Yeah, done and fix in the last commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
==========================================
+ Coverage 73.37% 73.42% +0.04%
==========================================
Files 174 174
Lines 24997 24997
==========================================
+ Hits 18342 18353 +11
+ Misses 5909 5898 -11
Partials 746 746 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, TY @Mujhtech
Description:
This pull request refactors the account helper functions in the codebase. It introduces a new helper function for creating a new account and removes the old account helper function. The refactoring also includes replacing the old account helper function with the new one in relevant parts of the code.
Related issue(s):
Fixes #1052
Notes for reviewer:
Checklist