feat: Remove hedera-protobufs-go dependency and add hedera-protobufs as submodule
#1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
- Coverage 73.44% 73.39% -0.05%
==========================================
Files 174 174
Lines 24999 24999
==========================================
- Hits 18360 18349 -11
- Misses 5894 5905 +11
Partials 745 745 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ivan Ivanov <[email protected]>
0xivanov
commented
Oct 15, 2024
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
0xivanov
changed the title
hedera-protobufs-go dependency and add hedera-protobufs as submodulehedera-protobufs-go dependency and add hedera-protobufs as submodule
Signed-off-by: Ivan Ivanov <[email protected]>
…om-hedera-protobufs
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
|
0xivanov
commented
Oct 16, 2024
0xivanov
deleted the
1099-Migrate-protobuf-definitions-to-pull-from-hedera-protobufs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #1099
Notes for reviewer:
Checklist