Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Panic when node account id is not in network list #805

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

bamzedev
Copy link
Contributor

@bamzedev bamzedev commented Sep 19, 2023

Description:
When a transaction has Node Account Id with is not present in the current network the client panics. This PR fixes this. It should now fail gracefully.

Related issue(s):

Fixes #802

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (a188610) 69.52% compared to head (046f586) 69.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #805      +/-   ##
===========================================
+ Coverage    69.52%   69.54%   +0.02%     
===========================================
  Files          164      164              
  Lines        33872    33875       +3     
===========================================
+ Hits         23548    23558      +10     
+ Misses        8956     8951       -5     
+ Partials      1368     1366       -2     
Files Changed Coverage Δ
network.go 84.02% <100.00%> (+0.33%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bamzedev bamzedev requested a review from rokn September 19, 2023 12:54
network.go Show resolved Hide resolved
@bamzedev bamzedev merged commit e93302b into develop Sep 19, 2023
9 checks passed
@bamzedev bamzedev deleted the fix/panic-when-missing-node branch September 19, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK Panics if node account id not in the network list
2 participants