Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #810

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Various fixes #810

merged 1 commit into from
Sep 27, 2023

Conversation

rokn
Copy link
Contributor

@rokn rokn commented Sep 26, 2023

Description:

  • fix serialization issues
  • fix auto renew on token create tx
  • fix return type on system delete tx

Related issue(s):

Fixes #809

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f7e9c4b) 69.58% compared to head (e63a11f) 69.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #810   +/-   ##
========================================
  Coverage    69.58%   69.59%           
========================================
  Files          164      164           
  Lines        33899    33899           
========================================
+ Hits         23590    23592    +2     
+ Misses        8942     8939    -3     
- Partials      1367     1368    +1     
Files Coverage Δ
file_append_transaction.go 69.94% <100.00%> (ø)
token_create_transaction.go 84.70% <100.00%> (+0.37%) ⬆️
topic_create_transaction.go 82.91% <100.00%> (ø)
topic_message_submit_transaction.go 75.07% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- fix auto renew on token create tx
- fix return type on system delete tx

Signed-off-by: Antonio Mindov <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rokn rokn merged commit 431e8ae into develop Sep 27, 2023
9 checks passed
@rokn rokn deleted the fix/serialization-fixes branch September 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various Hedera go sdk issues/inconsistencies found while working on wallet connect support
2 participants