New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove 'org.owasp:dependency-check-gradle' plugin #14246

Merged

jjohannes merged 1 commit into develop from 11230-remove-owasp-gradle-plugin

Jul 19, 2024

Collaborator

jjohannes commented Jul 15, 2024

Description:

This plugin has not been used for months. The functionality of finding vulnerabilities is covered by Snyk at the moment.

Related issue(s):

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

jjohannes added this to the v0.53 milestone

jjohannes self-assigned this

jjohannes requested a review from a team as a code owner

July 15, 2024 15:42

jjohannes requested a review from rbarkerSL

July 15, 2024 15:42

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 6m 11s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Token) Results

22 files 22 suites 6m 14s ⏱️
280 tests 280 ✅ 0 💤 0 ❌
359 runs 359 ✅ 0 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Restart) Results

7 files 7 suites 8m 51s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Crypto) Results

24 files 24 suites 14m 51s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs 372 ✅ 0 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Misc) Results

59 files 59 suites 16m 45s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs 398 ✅ 0 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 23m 27s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: HAPI Test (Smart Contract) Results

83 files 83 suites 26m 31s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs 758 ✅ 0 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

github-actions bot commented Jul 15, 2024 •

edited

Loading

Node: Unit Test Results

1 533 files 1 533 suites 4h 8m 55s ⏱️
115 831 tests 115 773 ✅ 58 💤 0 ❌
124 039 runs 123 981 ✅ 58 💤 0 ❌

Results for commit d28591d.

♻️ This comment has been updated with latest results.

codecov bot commented Jul 15, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.62%. Comparing base (9973fae) to head (533603b).
Report is 141 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #14246      +/-   ##
=============================================
- Coverage      67.58%   57.62%   -9.97%     
+ Complexity     36486    21881   -14605     
=============================================
  Files           3732     2853     -879     
  Lines         149767   109854   -39913     
  Branches       15571    11255    -4316     
=============================================
- Hits          101223    63302   -37921     
+ Misses         44179    42980    -1199     
+ Partials        4365     3572     -793

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jjohannes force-pushed the 11230-remove-owasp-gradle-plugin branch from 1aad141 to 533603b Compare

July 15, 2024 17:49


          build: Remove 'org.owasp:dependency-check-gradle' plugin

d28591d

This plugin has not been used for months. The functionality of finding
vulnerabilities is covered by Snyk at the moment.

Signed-off-by: Jendrik Johannes <[email protected]>

jjohannes force-pushed the 11230-remove-owasp-gradle-plugin branch from 533603b to d28591d Compare

July 19, 2024 06:20

rbarkerSL approved these changes

View reviewed changes

Contributor

rbarkerSL left a comment

LGTM

jjohannes merged commit 74e427b into develop

40 of 41 checks passed

jjohannes deleted the 11230-remove-owasp-gradle-plugin branch

July 19, 2024 13:16

netopyr added a commit that referenced this pull request


          Merge branch 'develop' into 14166-add-storeRegistry-serviceApiRegistry

61fe9ce

* develop:
  feat: add new event hashing algorithm (#14340)
  fix: fixed a few issues on Dynamic Address Book (#14316)
  fix(gossip): wait outside of lock (#14336)
  feat: Implement pending state for airdrop purposes (#14276)
  chore: fix Javadoc warnings in 'platform' modules (#14338)
  chore: fix Javadoc warnings in 'test-clients' (#14337)
  chore: fix Javadoc warnings in 'services' modules (#14339)
  fix: 14230 platform state deserialization fix (#14334)
  fix: 14309: Drop KeyIndexType.SEQUENTIAL_INCREMENTING_LONGS support (#14323)
  feat: log socket exception stack trace periodically (#14318)
  fix: 14230 Fixed incorrect deserialization of `PlatformState` (#14332)
  feat: Add feature flag cookbook item (#14324)
  build: remove unused plugins (block-node) (#14254)
  build: Remove 'org.owasp:dependency-check-gradle' plugin (#14246)
  fix: remove hard dependency on 'commons.compress' (#14240)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ReadableStoreFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/ServiceApiFactory.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/store/WritableStoreFactory.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet