Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename directory 'swirlds-jasperdb' to 'swirlds-merkledb' #15143

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Aug 27, 2024

Description:

To have a directory name consistent with the Module/Artifact name.

Note: This rename is a pure renaming of the folder for consistency. It does not change any name/id inside the software.

Related issue(s):

#14255

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes added this to the v0.54 milestone Aug 27, 2024
@jjohannes jjohannes self-assigned this Aug 27, 2024
@jjohannes jjohannes requested review from a team as code owners August 27, 2024 15:03
jsync-swirlds
jsync-swirlds previously approved these changes Aug 27, 2024
Copy link

codacy-production bot commented Aug 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (db414c7) 112867 68480 60.67%
Head commit (9904c19) 112867 (+0) 68480 (+0) 60.67% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15143) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (db414c7) to head (9904c19).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15143   +/-   ##
==========================================
  Coverage      57.23%   57.23%           
  Complexity     22026    22026           
==========================================
  Files           2912     2912           
  Lines         113051   113051           
  Branches       11526    11526           
==========================================
  Hits           64708    64708           
  Misses         44459    44459           
  Partials        3884     3884           
Files with missing lines Coverage Δ
...java/com/swirlds/merkledb/DataSourceValidator.java 0.00% <ø> (ø)
...b/src/main/java/com/swirlds/merkledb/KeyRange.java 81.25% <ø> (ø)
...b/src/main/java/com/swirlds/merkledb/MerkleDb.java 72.38% <ø> (ø)
...wirlds/merkledb/MerkleDbCompactionCoordinator.java 76.04% <ø> (ø)
.../java/com/swirlds/merkledb/MerkleDbDataSource.java 71.03% <ø> (ø)
...om/swirlds/merkledb/MerkleDbDataSourceBuilder.java 57.50% <ø> (ø)
.../main/java/com/swirlds/merkledb/MerkleDbPaths.java 100.00% <ø> (ø)
.../java/com/swirlds/merkledb/MerkleDbStatistics.java 94.11% <ø> (ø)
...om/swirlds/merkledb/MerkleDbStatisticsUpdater.java 81.05% <ø> (ø)
...java/com/swirlds/merkledb/MerkleDbTableConfig.java 79.56% <ø> (ø)
... and 27 more

Impacted file tree graph

mxtartaglia-sl
mxtartaglia-sl previously approved these changes Aug 28, 2024
@jjohannes jjohannes force-pushed the 15009-rename-directory-to-merkledb branch 2 times, most recently from ab855ff to 931f03e Compare August 29, 2024 09:31
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Aug 29, 2024
To have a directory name consistent with the Module/Artifact name.

Signed-off-by: Jendrik Johannes <[email protected]>
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjohannes jjohannes merged commit 6c2a39a into develop Sep 2, 2024
50 checks passed
@jjohannes jjohannes deleted the 15009-rename-directory-to-merkledb branch September 2, 2024 05:58
@poulok poulok modified the milestones: v0.54, v0.55 Sep 3, 2024
netopyr added a commit that referenced this pull request Sep 5, 2024
* develop: (727 commits)
  chore: Bump services version to 0.55 (#15321)
  fix: Prevent designating deleted accounts as custom fee collectors (#15339)
  chore: add unit tests for `ServicesSoftwareVersion` utilities (#15326)
  chore: Remove the script forensic/start-investigation.py (#14264)
  ci: disable release 0.52 regression (#15228)
  chore: Integrate protobufs to build (#15324)
  fix: stop using raw types in `Call{Attempt,Translator}`  (#15331)
  chore: Refactor and Remove Duplicate Documentation in Services (#15286)
  feat: 15146 Added `calculateHash`, `setHash` and `getHash` methods to `State` interface (#15274)
  fix: 10342: HashListByteBuffer releases DirectByteBuffers lazily, adds memory pressure (#15296)
  fix: if the directory exist, don't create it in UnzipUtility (#15319)
  fix: use `ServicesSoftwareVersion` (#15294)
  test: add a sigRequired true additional test (#15267)
  fix: code style and javadoc fixes (#15298)
  chore: remove 'itest' test set (#15276)
  chore: rename directory 'swirlds-jasperdb' to 'swirlds-merkledb' (#15143)
  test: Token Claim Airdrop with receiverSigReq test (#15279)
  chore: 11771 Added more unit tests for `WritablePlatformStateStore` (#15268)
  chore: remove unused `hedera-evm-*` and `cli-clients` modules (#15271)
  docs: tss ledger id platform design proposal (#13747)
  ...

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/cache/CacheWarmer.java
rbarkerSL pushed a commit that referenced this pull request Sep 5, 2024
stoyanov-st pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants