Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cleanup settings.gradle.kts / remove build.gradle.kts #15470

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jjohannes
Copy link
Collaborator

Description:

In preparation for reusable build config (#14255 / #15282):

  • Protobuf versions are now also managed in 'hedera-dependency-versions'
  • Root 'build.gradle.kts' removed (config done in plugins)
  • Special project – 'hedera-dependency-versions' and 'reports' – are defined in plugins as they'll be the same in all Hedera projects

Related issue(s):

#14255 / #15282

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

- Protobuf versions are now also managed in 'hedera-dependency-versions'
- Root 'build.gradle.kts' removed (config done in plugins)
- Special project – 'hedera-dependency-versions' and 'reports' – are
  defined in plugins as they'll be the same in all Hedera projects

Signed-off-by: Jendrik Johannes <[email protected]>
@jjohannes jjohannes added this to the v0.55 milestone Sep 16, 2024
@jjohannes jjohannes self-assigned this Sep 16, 2024
@jjohannes jjohannes requested review from a team as code owners September 16, 2024 07:15
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aaff32c) 109106 67425 61.80%
Head commit (52ace95) 109106 (+0) 67412 (-13) 61.79% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15470) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (aaff32c) to head (52ace95).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15470      +/-   ##
=============================================
- Coverage      58.25%   58.24%   -0.02%     
+ Complexity     21613    21609       -4     
=============================================
  Files           2781     2781              
  Lines         109289   109289              
  Branches       11181    11181              
=============================================
- Hits           63668    63652      -16     
- Misses         41754    41767      +13     
- Partials        3867     3870       +3     

see 22 files with indirect coverage changes

Impacted file tree graph

@jjohannes jjohannes merged commit 6473cc7 into develop Sep 17, 2024
64 of 65 checks passed
@jjohannes jjohannes deleted the 14255-protobuf-versions branch September 17, 2024 18:11
netopyr added a commit that referenced this pull request Sep 19, 2024
* develop: (22 commits)
  test: New HAPI test for TokenAirdrop transaction (#15348)
  test: unit test verifySyncInvalidEd25519() is not stable (#15534)
  chore: add `TracerBinding` interface for `TransactionExecutors`. (#15480)
  chore: Add missing javadocs in Consensus Service (#15299)
  fix: Validate `CustomFees` input arrays in `UpdateTokenCustomFeesDecoder` (#15520)
  feat: migrate event serialization to protobuf (#15417)
  fix: 15494: Improve VirtualLeafRecord serialization to bytes during flushes (#15512)
  docs: tss block signing proposal (#15160)
  fix: 15438: Eliminate busy loop in HalfDiskHashMap.endWriting() (#15439)
  build: cleanup settings.gradle.kts / remove build.gradle.kts (#15470)
  test: fix CryptographyTests (#15529)
  fix: recreate block hash from state (#15444)
  docs: Proposal Process Update - Specify post-acceptance non-material update procedure (#15447)
  chore: testnet event hashing (#15432)
  fix: 15167: Remove timeout from reconnect/rehash Iterators (#15468)
  chore: remove snapshot ops (#15462)
  feat: Add TokenUpdateNFTs as a smart contract operation v2 (#15445)
  feat: introduce PbjRecordHasher and RosterUtils.hash(Roster) (#15457)
  fix: Precision loss for gas calculation of HTS system contracts v2 (#15446)
  chore: correct the variable name in roster.proto (#15465)
  ...

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/scope/HandleHederaOperations.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants