Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LegacyConfigPropertiesLoader should not suppress ParseException #16133

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

fix: LegacyConfigPropertiesLoader should not suppress ParseException

9a59e75
Select commit
Loading
Failed to load commit list.
Open

fix: LegacyConfigPropertiesLoader should not suppress ParseException #16133

fix: LegacyConfigPropertiesLoader should not suppress ParseException
9a59e75
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 25, 2024 in 0s

58.04% (+0.01%) compared to b447146

View this Pull Request on Codecov

58.04% (+0.01%) compared to b447146

Details

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (b447146) to head (9a59e75).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...rm/config/legacy/LegacyConfigPropertiesLoader.java 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16133      +/-   ##
=============================================
+ Coverage      58.02%   58.04%   +0.01%     
- Complexity     19744    19749       +5     
=============================================
  Files           2724     2724              
  Lines          99673    99665       -8     
  Branches       10289    10287       -2     
=============================================
+ Hits           57834    57846      +12     
+ Misses         38233    38216      -17     
+ Partials        3606     3603       -3     
Files with missing lines Coverage Δ
...rlds/platform/system/address/AddressBookUtils.java 72.85% <ø> (+2.02%) ⬆️
...rm/config/legacy/LegacyConfigPropertiesLoader.java 69.23% <0.00%> (+4.01%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph