feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 #800

quiet-node · 2024-06-10T22:46:34Z

Description:

renamed IHRC contracts to IHRC719 as IHRC632 is being included
included IHRC632. IHRC632 allows an EOA to act as an SC with IHRC632 interface, walletAIHrc632 = new Contract(walletA.address, IHRC632, walletA);. This will make it possible for the EOA to directly make calls to the HAS precompile contracts, hence making the EOA top level caller of the transaction without any help from a third party like another SC account. That's when Hip-906 kicks in and allow hbar owner, top level caller, grant an hbar allowance to a spender.
added cyprtoTransfer to CryptoAllowance to showcase support in HIP906

Related issue(s):

Fixes #797

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-06-10T22:53:54Z

Test Results

  17 files +  3   86 suites +16 7m 54s ⏱️ + 1m 18s
254 tests +19 246 ✔️ +17   7 💤 +1 1 ❌ +1
286 runs +51 275 ✔️ +46 10 💤 +4 1 ❌ +1

For more details on these failures, see this check.

Results for commit 18f0900. ± Comparison against base commit 024064d.

♻️ This comment has been updated with latest results.

AlfredoG87

overall looks good, leaved some nits and comments.

Also, I would like to see the test cases defined as:

Grant Allowance (approve) from EOA to EOA
Grant Allowance (approve) from EOA to Contract
Grant Allowance (approve) from Contract to EOA
Grant Allowance (approve) from Contract to Contract
Get Current Allowance from owner account to another Account
Get Current Allowance from owner account to an Smart Contract

I also think that the correct resolution of these scenarios will need for the EOA to call the system contract directly. due to Security model limitations.

Finally, not sure why are we adding this examples and tests as part of the HTS-Precompile folder, since is not related to HTS transfers but I would place it in its own folder called HAS-SystemContract (Hedera Account Service System Contract)

.github/workflows/tests.yml

contracts/hts-precompile/examples/crypto-allowance/cryptoAllowance.sol

test/hts-precompile/crypto-allowance/cryptoAllowance.js

test/hts-precompile/utils.js

test/hts-precompile/crypto-allowance/cryptoAllowance.js

lukelee-sl · 2024-06-12T20:32:38Z

test/hts-precompile/crypto-allowance/cryptoAllowance.js

+    expect(logs.args[2]).to.eq(amount);
+  });
+
+  it('Should NOT allow an approval on behalf of hbar owner WINTHOUT its signature', async () => {


nit: WINTHOUT -> WITHOUT

test/hts-precompile/crypto-allowance/cryptoAllowance.js

lukelee-sl

LGTM. tyvm!

quiet-node · 2024-06-13T17:36:51Z

overall looks good, leaved some nits and comments.

Also, I would like to see the test cases defined as:

Grant Allowance (approve) from EOA to EOA

Grant Allowance (approve) from EOA to Contract

Grant Allowance (approve) from Contract to EOA

Grant Allowance (approve) from Contract to Contract

Get Current Allowance from owner account to another Account

Get Current Allowance from owner account to an Smart Contract

I also think that the correct resolution of these scenarios will need for the EOA to call the system contract directly. due to Security model limitations.

Finally, not sure why are we adding this examples and tests as part of the HTS-Precompile folder, since is not related to HTS transfers but I would place it in its own folder called HAS-SystemContract (Hedera Account Service System Contract)

@AlfredoG87

Grant Allowance (approve) from EOA to EOA
- EOA -> EOA via HAS
- EOA -> EOA via IHRC632
Grant Allowance (approve) from EOA to Contract
- EOA -> SC via IHRC632
Grant Allowance (approve) from Contract to EOA
- SC -> EOA via HAS
Grant Allowance (approve) from Contract to Contract
- contract -> contract via IHRC632 + IHAS
Get Current Allowance from owner account to another Account
- allowance from an SC to EOA
Get Current Allowance from owner account to an Smart Contract
- allowance from EOA to another account

AlfredoG87

LGTM

lukelee-sl

LGTM

Signed-off-by: Logan Nguyen <[email protected]>

…HIP906 Signed-off-by: Logan Nguyen <[email protected]>

…ar allowance to another contract Signed-off-by: Logan Nguyen <[email protected]>

Signed-off-by: Logan Nguyen <[email protected]>

Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: lukelee-sl <[email protected]> Signed-off-by: Logan Nguyen <[email protected]>

…HIP906 (hashgraph#800) * feat: added CryptoAllowance wrapper example contract Signed-off-by: Logan Nguyen <[email protected]> * test: added test coverage for CryptoAllowance Signed-off-by: Logan Nguyen <[email protected]> * fix: renamed IHRC to IHRC719 Signed-off-by: Logan Nguyen <[email protected]> * feat: added IHRC632 Signed-off-by: Logan Nguyen <[email protected]> * feat: added cyprtoTransfer to CryptoAllowance to showcase support in HIP906 Signed-off-by: Logan Nguyen <[email protected]> * feat: added use case to showcase the support for contract granting hbar allowance to another contract Signed-off-by: Logan Nguyen <[email protected]> * ci: added CryptoAllowance to PublishResults Signed-off-by: Logan Nguyen <[email protected]> * fix: added return statements for hbarAllowancePublic Signed-off-by: Logan Nguyen <[email protected]> * fix: stored SC addresses into constants Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed typo Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed typo Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: lukelee-sl <[email protected]> Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: lukelee-sl <[email protected]>

quiet-node added the enhancement New feature or request label Jun 10, 2024

quiet-node self-assigned this Jun 10, 2024

quiet-node requested review from AlfredoG87, attest08, ebadiere, georgi-l95, Ivo-Yankov, natanasow, yiliev0, a team and Nana-EC as code owners June 10, 2024 22:46

quiet-node requested review from matteriben and rbarkerSL June 10, 2024 22:46

quiet-node marked this pull request as draft June 11, 2024 01:05

AlfredoG87 reviewed Jun 12, 2024

View reviewed changes

lukelee-sl reviewed Jun 12, 2024

View reviewed changes

AlfredoG87 changed the title ~~feat: added cyprtoTransfer to CryptoAllowance to showcase support in HIP906~~ feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 Jun 12, 2024

lukelee-sl reviewed Jun 13, 2024

View reviewed changes

test/hts-precompile/crypto-allowance/cryptoAllowance.js Outdated Show resolved Hide resolved

lukelee-sl previously approved these changes Jun 13, 2024

View reviewed changes

quiet-node mentioned this pull request Jun 13, 2024

feat: added CryptoAllowance example wrapper contract #798

Closed

2 tasks

quiet-node dismissed lukelee-sl’s stale review via ffe5458 June 13, 2024 16:22

AlfredoG87 approved these changes Jun 13, 2024

View reviewed changes

quiet-node force-pushed the 797-create-tests-for-hip-206906-part-2 branch from 33aba67 to 2c264cd Compare June 14, 2024 21:17

lukelee-sl approved these changes Jun 14, 2024

View reviewed changes

quiet-node added 2 commits June 17, 2024 13:49

feat: added CryptoAllowance wrapper example contract

ee94e17

Signed-off-by: Logan Nguyen <[email protected]>

test: added test coverage for CryptoAllowance

b477c32

Signed-off-by: Logan Nguyen <[email protected]>

quiet-node and others added 9 commits June 17, 2024 13:49

fix: renamed IHRC to IHRC719

3f6626f

Signed-off-by: Logan Nguyen <[email protected]>

feat: added IHRC632

6880c54

Signed-off-by: Logan Nguyen <[email protected]>

feat: added cyprtoTransfer to CryptoAllowance to showcase support in …

f459e4c

…HIP906 Signed-off-by: Logan Nguyen <[email protected]>

feat: added use case to showcase the support for contract granting hb…

672d354

…ar allowance to another contract Signed-off-by: Logan Nguyen <[email protected]>

ci: added CryptoAllowance to PublishResults

0b95c30

Signed-off-by: Logan Nguyen <[email protected]>

fix: added return statements for hbarAllowancePublic

de7dee6

Signed-off-by: Logan Nguyen <[email protected]>

fix: stored SC addresses into constants

b596f24

Signed-off-by: Logan Nguyen <[email protected]>

fix: fixed typo

2a503b3

Signed-off-by: Logan Nguyen <[email protected]>

fix: fixed typo

18f0900

Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: lukelee-sl <[email protected]> Signed-off-by: Logan Nguyen <[email protected]>

quiet-node force-pushed the 797-create-tests-for-hip-206906-part-2 branch from 2c264cd to 18f0900 Compare June 17, 2024 17:49

quiet-node marked this pull request as ready for review June 17, 2024 17:49

quiet-node merged commit 4241394 into main Jun 17, 2024
26 of 27 checks passed

quiet-node deleted the 797-create-tests-for-hip-206906-part-2 branch June 17, 2024 18:15

quiet-node mentioned this pull request Jul 12, 2024

Create end to end tests for atomic crypto transfer #132

Closed

quiet-node added this to the 0.8.0 milestone Jul 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 #800

feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 #800

quiet-node commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

AlfredoG87 left a comment

lukelee-sl Jun 12, 2024

quiet-node Jun 13, 2024

lukelee-sl left a comment

quiet-node commented Jun 13, 2024 •

edited

Loading

AlfredoG87 left a comment

lukelee-sl left a comment

feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 #800

feat: added cryptoTransfer to CryptoAllowance to showcase support in HIP906 #800

Conversation

quiet-node commented Jun 10, 2024 • edited Loading

github-actions bot commented Jun 10, 2024 • edited Loading

Test Results

AlfredoG87 left a comment

Choose a reason for hiding this comment

lukelee-sl Jun 12, 2024

Choose a reason for hiding this comment

quiet-node Jun 13, 2024

Choose a reason for hiding this comment

lukelee-sl left a comment

Choose a reason for hiding this comment

quiet-node commented Jun 13, 2024 • edited Loading

AlfredoG87 left a comment

Choose a reason for hiding this comment

lukelee-sl left a comment

Choose a reason for hiding this comment

quiet-node commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

quiet-node commented Jun 13, 2024 •

edited

Loading