ci: Updating one of the actions to fix issues with inputs. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasil Boyadzhiev <[email protected]>
nathanklick
previously requested changes
Oct 14, 2024
quiet-node
added
enhancement
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
rbarkerSL
approved these changes
Oct 19, 2024
andrewb1269hg
approved these changes
Oct 22, 2024
san-est
dismissed
nathanklick’s stale review
Issues in review were fixed and approvals afterwards were added.
san-est
deleted the
957-manual-testing-permissions-update-with-a-boolean
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The updated version of the action publish-unit-test-result in the workflow requires new inputs, this PR aims to fix that.
Additionally the attached issue to this PR aimed to see if we can have variable permissions based on how the workflow is run. However, I could not find a suitable solution for the moment and the only action that takes advantage of the extra permissions is publish-test-results so I see no security implications currently.
Related issue(s):
Fixes #957
Notes for reviewer:
Checklist