Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of ordindary DNS provider for query plain old DNS records #186

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prologic
Copy link

Closes #185

@dnephin
Copy link
Contributor

dnephin commented Jan 18, 2022

Thank you for the PR! I'd like to better understand your use case. Are you using this library directly, or are you hoping for this support in Consul (or some other HashiCorp product) ?

@prologic
Copy link
Author

prologic commented Jan 19, 2022

Thank you for the PR! I'd like to better understand your use case. Are you using this library directly, or are you hoping for this support in Consul (or some other HashiCorp product) ?

I'm hoping this will get into go-discover itself so that ordinary DNS-based Service Discovery, such as that found in any non-public cloud infrastructure can be used in Hashicorp products ​such as Consul and Vault.

Thank you for the consideration 🙇‍♂

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@prologic
Copy link
Author

NB: I've rebased this on #200 for the time being. Fixed the tests and blakiness and this PR should be ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for DNS discovery
4 participants