Add expirable LRU finalizer to fix expirable LRU's goroutine leak #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the trick used in go-cache to solve go routine leak when dynamically creating many expirable-LRU cache. #159
The deleteExpired go routine will be terminated by finalizer at some garbage collection time in the future, although not immediately after cache goes out of scope.
This trick is wrapping the lru type and does not affect exposed APIs. If LRU.Close() method will be re-added in the future, a small change is needed to prevent double close over c.done. But for now, the only caller of close(c.done) is the finalizer, and the finalizer must be called only once, so it's OK for now.