Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23671 Added synopsis for operator root and operator gossip command. #23855

Merged
merged 8 commits into from
Oct 18, 2024
Merged

#23671 Added synopsis for operator root and operator gossip command. #23855

merged 8 commits into from
Oct 18, 2024

Conversation

raj-hegde
Copy link
Contributor

@raj-hegde raj-hegde commented Aug 22, 2024 •
edited by jrasell
Loading

Synopsis comment for both gossip and root section has been added. Added the respective command files for each of the subcommands.

closes #14881
closes #23671

@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Aug 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@raj-hegde
Copy link
Contributor Author

Please give feedback if I did anything wrong.

jrasell
jrasell requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raj-hegde and thank you very much for raising this PR. I have added some minor suggestions for you to look at. Once these are resolved, I will get this PR merged.

Also, if you could add a changelog entry via the make cl command, that would be awesome.

command/operator_gossip.go Outdated Show resolved Hide resolved
command/operator_gossip.go Outdated Show resolved Hide resolved
command/operator_root.go Outdated Show resolved Hide resolved
command/operator_root.go Outdated Show resolved Hide resolved
command/operator_root.go Outdated Show resolved Hide resolved
@jrasell jrasell self-assigned this Sep 18, 2024
@jrasell jrasell added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line labels Sep 18, 2024
@raj-hegde
Copy link
Contributor Author

Hi @jrasell, Thanks for the feedback I'll work on it right away.

@raj-hegde
Copy link
Contributor Author

Hi @jrasell removed white spaces keeping consistency with other commands and changed the args function operator to underscore. Also made a changlelog entry.

Any feedback is greatly appreciated.

@jrasell jrasell added backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line and removed backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/1.8.x backport to 1.8.x release line labels Oct 18, 2024
jrasell
jrasell approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @raj-hegde. I pushed a couple of minor changes and will now get this merged.

@jrasell jrasell merged commit 42eacc8 into hashicorp:main Oct 18, 2024
17 of 18 checks passed
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

@jrasell jrasell

Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line
Projects
Nomad - Community Issues Triage
Status: Done
Milestone
No milestone
2 participants
@raj-hegde @jrasell