This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Num servers #136
Open
Num servers #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I wonder how you tested this? |
|
Hey, currently the automated tests are failing due to some issue with amazon linux which is currently why Im not merging this and other PRs. Ill try to have a look later, but feel free to give it a check too |
|
Could you please rebase your PR now that a fix has been issued? |
|
Will do.
…On Thu, May 30, 2019 at 2:18 AM Etiene Dalcol ***@***.***> wrote:
Could you please rebase your PR now that a fix has been issued?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#136?email_source=notifications&email_token=AAFQWTKJFVIJ57MPITD67QDPX3CHVA5CNFSM4HLXLLKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQGRPI#issuecomment-497051837>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFQWTK3ZTAU3BJPEXQUYWLPX3CHVANCNFSM4HLXLLKA>
.
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for explicitly specifying the number of servers in the cluster. In AWS configurations where access to the Internet is restricted, and since there is no AWS EC2 endpoint service for autoscaling, there is no way to ask AWS for the size of the ASG.