-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add support for terraform's parallelism flag #2107
Conversation
fe0dcb1
to
4ce7fa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @mutahhir 🎉 Good job cleaning up some old code as well 👍
Only a couple small nits / questions 🙂
97d4739
to
8132ff6
Compare
…t faster by mocking
8132ff6
to
cdf3a2e
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #1715
This PR adds the
-terraform-parallelism
flag to the CLI. This flag is only available fordeploy
anddestroy
. One note here is that due the nature ofdeploy
, the parallelism flag will be used for bothplan
andapply
within the Terraform CLI during thedeploy
operation.One thing to note: The
parallelism
flag is not supported by Terraform Cloud, so setting that for remote backends will be ignored.Also, now now have two
parallelism
flags. One is--parallelism
and the other is--terraform-parallelism
. The former only affects howcdktf
processes multiple stacks, while the latter is passed on to the Terraform CLI and changes how many concurrent operations Terraform starts as it walks the graph.