Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add support for terraform's parallelism flag #2107

Merged
merged 18 commits into from
Oct 13, 2022

Conversation

mutahhir
Copy link
Member

@mutahhir mutahhir commented Sep 13, 2022

Fixes #1715

This PR adds the -terraform-parallelism flag to the CLI. This flag is only available for deploy and destroy. One note here is that due the nature of deploy, the parallelism flag will be used for both plan and apply within the Terraform CLI during the deploy operation.

One thing to note: The parallelism flag is not supported by Terraform Cloud, so setting that for remote backends will be ignored.

Also, now now have two parallelism flags. One is --parallelism and the other is --terraform-parallelism. The former only affects how cdktf processes multiple stacks, while the latter is passed on to the Terraform CLI and changes how many concurrent operations Terraform starts as it walks the graph.

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @mutahhir 🎉 Good job cleaning up some old code as well 👍
Only a couple small nits / questions 🙂

packages/cdktf-cli/bin/cmds/handlers.ts Show resolved Hide resolved
packages/cdktf-cli/lib/cdktf-project.ts Show resolved Hide resolved
packages/cdktf-cli/lib/cdktf-stack.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/test/lib/cdktf-project.test.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/test/lib/cdktf-project.test.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with @cdktf/provider-postgresql Grant (Add terraform-parallelism flag)
5 participants